Created a simulation of the Enigma encryption as a historical crypto module. #38292
Conversation
There was a problem hiding this comment.
Thanks for contributing this! I'm not familiar enough with Enigma to check for correctness but it looks like you've done a good job including lots of tests. This was just a first pass at review, I probably missed a few things.
Make sure the tests pass and review the Sage developer guide, in particular:
| # **************************************************************************** | ||
|
|
||
|
|
||
| class Rotor: |
There was a problem hiding this comment.
Sage classes should inherit from SageObject: https://doc.sagemath.org/html/en/developer/coding_in_python.html
| ) | ||
|
|
||
|
|
||
| class Reflector: |
There was a problem hiding this comment.
Inherit from SageObject
| ValueError: Reflector must be a value between 1 and 3 | ||
| """ | ||
|
|
||
| wheels = [ |
There was a problem hiding this comment.
Does it fit on one line? Not a big deal though. We use a maximum line length of 80 characters.
| # plugboard and reflector are static permutations anyway | ||
| return Enigma(new_rotors, self._reflector, self._plugboard) | ||
|
|
||
| def __repr__(self) -> str: |
There was a problem hiding this comment.
Classes inheriting from SageObject should define _repr_ instead of __repr__
There was a problem hiding this comment.
Classes should also define _latex_
As part of a study project from our University HAW Landshut we created a simulation of the Enigma machine used in World War II by the German Army.
This module includes the possibility to create all used Enigma machines and took it one step further, so you can create your own version.
Our goal was to give fellow students the possibility to play around with historical cryptography that was considered safe (at least from one side) unbreakable.
📝 Checklist
⌛ Dependencies