-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/pkgs/playwright
: New package for screenshotting 3d graphics as png
#38509
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit b320e53; changes) is ready! 🎉 |
build/pkgs/playwright
, playwright_chromium
: New packages for screenshottingbuild/pkgs/playwright
, playwright_chromium
: New packages for screenshotting 3d graphics as png
Yum python packages all the way. I was afraid of big bad nodejs. I have questions :)
|
Here on macOS, I didn't see a window pop up. Haven't tested on Linux.
I haven't seen any options to use browsers other than the ones it is providing. I'd also be quite skeptical about any solution that promised doing that. |
nbconvert installs chromium at runtime. We probably should do the same instead of my current solution of using the script package |
Done now |
build/pkgs/playwright
, playwright_chromium
: New packages for screenshotting 3d graphics as pngbuild/pkgs/playwright
: New package for screenshotting 3d graphics as png
Doesn't show in HTML documentation |
After installing the package using
sage -i playwright
, we can now save threejs renders as png files. Upon first use, the chromium browser is installed automatically.Relevant API:
The "webpdf" technology of nbconvert also currently uses playwright. https://github.com/jupyter/nbconvert/blob/main/pyproject.toml#L66
Discussion: https://groups.google.com/g/sage-devel/c/pj76chTb348
📝 Checklist
⌛ Dependencies