Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/tachyon: Fix rpath #38534

Merged
merged 2 commits into from
Sep 3, 2024
Merged

build/pkgs/tachyon: Fix rpath #38534

merged 2 commits into from
Sep 3, 2024

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Aug 20, 2024 •
edited
Loading

Tests at https://github.com/mkoeppe/sage/actions/runs/10464240837/job/28977512582

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Aug 20, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 069f036; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe marked this pull request as ready for review August 20, 2024 19:18
kwankyu
kwankyu reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@mkoeppe
Copy link
Author

mkoeppe commented Aug 27, 2024

Thank you.

@mkoeppe mkoeppe added this to the sage-10.5 milestone Aug 29, 2024
@vbraun vbraun merged commit 677a120 into sagemath:develop Sep 3, 2024
27 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu left review comments

Assignees

@mkoeppe mkoeppe

Labels
c: graphics c: packages: standard p: blocker / 1
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.

tachyon runtime errors related to libpng
3 participants
@mkoeppe @kwankyu @vbraun