Fix time limitation in magma_free docstring #38765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Eloitor since the CI is failing to build the docs, before I approve this I want to ask if you've built the documentation locally? |
|
I didn't for this small change. |
vincentmacri
reviewed
Oct 4, 2024
vincentmacri
reviewed
Oct 4, 2024
Co-authored-by: Vincent Macri <[email protected]>
Co-authored-by: Vincent Macri <[email protected]>
|
Documentation preview for this PR (built with commit 0d9a010; changes) is ready! 🎉 |
tscrim
requested changes
Oct 7, 2024
Co-authored-by: Travis Scrimshaw <[email protected]>
vincentmacri
reviewed
Oct 7, 2024
Co-authored-by: Vincent Macri <[email protected]>
vincentmacri
added
s: positive review
c: documentation
and removed
s: needs review
labels
|
LGTM, thanks for the contribution! |
tscrim
approved these changes
Oct 8, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 9, 2024
<!-- v Describe your changes below in detail. --> Change time limitation from 20 to 120 in the documentation of magma_free. <!-- v Why is this change required? What problem does it solve? --> > Calculations are restricted to 120 seconds. http://magma.maths.usyd.edu.au/calc/ > <max_time>120</max_time> http://magma.maths.usyd.edu.au/xml/calculator.xml?input=Factorization(15 ) <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38765 Reported by: Eloi Torrents Reviewer(s): Travis Scrimshaw, Vincent Macri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change time limitation from 20 to 120 in the documentation of magma_free.
📝 Checklist
⌛ Dependencies