Addition of new presentations to Chow rings of matroids #39359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25shriya
changed the title
|
Documentation preview for this PR (built with commit 7545335; changes) is ready! 🎉 |
tscrim
reviewed
Jan 22, 2025
| @@ -92,7 +92,7 @@ class ChowRing(QuotientRing_generic): | |||
| Chow ring of P8'': Matroid of rank 4 on 8 elements with 8 nonspanning circuits | |||
| over Rational Field | |||
| """ | |||
| def __init__(self, R, M, augmented, presentation=None): | |||
| def __init__(self, R, M, augmented, presentation='fy'): | |||
There was a problem hiding this comment.
It is better for this to be None as then have the augmented True/False set its own default. It might be something we want changed later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on adding the atom-free and simplicial presentation of Chow rings of matroids. see relevant issue
The former is taken from Definition 4.1 of this paper and the latter from Definition 3.2.1 of this paper.
@tscrim
📝 Checklist
⌛ Dependencies