Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update outdated [email protected] #7945

Open
haraldschilly opened this issue Oct 15, 2024 · 5 comments · Fixed by #7953
Open

update outdated [email protected] #7945

haraldschilly opened this issue Oct 15, 2024 · 5 comments · Fixed by #7953

Comments

@haraldschilly
Copy link
Contributor

In static/package.json there is a loader: "html-minify-loader". It's not maintained for many years.

When I look into the webpack docs, there are 3 others: https://webpack.js.org/plugins/html-minimizer-webpack-plugin/

So, whatever is really going on, to me it looks like we have switch this html minimize loader.

@williamstein
Copy link
Contributor

ATTN: we no longer use webpack!! We have switched to rspack.

@haraldschilly
Copy link
Contributor Author

how does html processing then work? is this still in use?

@williamstein
Copy link
Contributor

@williamstein
Copy link
Contributor

@williamstein
Copy link
Contributor

The PR just completely breaks everything involving html. In particular, Sage worksheets don't load anymore. I checked and whatever you were doing replaced the contents of the file with the name of the file, hence doesn't work. I've reverted that PR, since I wasn't able to find a better approach in a short amount of time.

When we next work on this, there is one obvious test to do before considering it solved: actually open a sage worksheet.

@williamstein williamstein reopened this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants