-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update outdated [email protected] #7945
Comments
ATTN: we no longer use webpack!! We have switched to rspack. |
how does html processing then work? is this still in use? |
The PR just completely breaks everything involving html. In particular, Sage worksheets don't load anymore. I checked and whatever you were doing replaced the contents of the file with the name of the file, hence doesn't work. I've reverted that PR, since I wasn't able to find a better approach in a short amount of time. When we next work on this, there is one obvious test to do before considering it solved: actually open a sage worksheet. |
In
static/package.json
there is aloader: "html-minify-loader"
. It's not maintained for many years.When I look into the webpack docs, there are 3 others: https://webpack.js.org/plugins/html-minimizer-webpack-plugin/
So, whatever is really going on, to me it looks like we have switch this html minimize loader.
The text was updated successfully, but these errors were encountered: