Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static/webpack/npm: get rid of html-minify-loader #7953

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

haraldschilly
Copy link
Contributor

Goal is to get rid of html-minify-loader to fix #7945

In the end, this PR just gets rid of the minify loader. I don't know enough about webpack and all of this any more, though. It looks like there is a lot of opportunity to enhance this, but just regarding that loader, it only deals with existing html files – not generating them via plugin or whatever.

So, all possibly affected assets are:

...$ git ls-files HEAD '**/*.html'
frontend/account.html
frontend/console.html
frontend/editor.html
frontend/jupyter.html
frontend/sagews/3d.html
frontend/sagews/d3.html
frontend/sagews/interact.html

and surely, they are either small already or will go away anyways.

My understanding is that with this change, the html file is just copied over. There are ways to add a plugin for minifying html and set an optimization option – but that just causes a weird typescript error. In any case, I don't see the point in optimizing these few files.

@haraldschilly haraldschilly marked this pull request as ready for review October 16, 2024 15:15
@williamstein
Copy link
Contributor

surely, they are either small already or will go away anyways.

+1 and I agree with this.

@williamstein williamstein merged commit 7364593 into master Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update outdated [email protected]
2 participants