static/webpack/npm: get rid of html-minify-loader #7953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to get rid of html-minify-loader to fix #7945
In the end, this PR just gets rid of the minify loader. I don't know enough about webpack and all of this any more, though. It looks like there is a lot of opportunity to enhance this, but just regarding that loader, it only deals with existing html files – not generating them via plugin or whatever.
So, all possibly affected assets are:
and surely, they are either small already or will go away anyways.
My understanding is that with this change, the html file is just copied over. There are ways to add a plugin for minifying html and set an optimization option – but that just causes a weird typescript error. In any case, I don't see the point in optimizing these few files.