No multiarch out of tree #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thaodan
force-pushed
the
no_multiarch_out_of_tree
branch
13 times, most recently
from
2d657cb
to
5558364
Compare
Thaodan
force-pushed
the
no_multiarch_out_of_tree
branch
2 times, most recently
from
eda7b44
to
5ad4f24
Compare
Thaodan
force-pushed
the
no_multiarch_out_of_tree
branch
from
5ad4f24
to
bbd5c5d
Compare
i_virtualize_struct_statx was only implicitly defined in
vterm_statfuns.c as config.h which defines HAVE_STATX wasn't included.
Consistently include config.h before any other header to avoid issues
like these:
preload/vperm_filestatgates.c: In function ‘statx_gate’:
preload/vperm_filestatgates.c:272:17: error: implicit declaration of function ‘i_virtualize_struct_statx’; did you mean ‘i_virtualize_struct_stat’? [-Wimplicit-function-declaration]
272 | i_virtualize_struct_statx(realfnname, buf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| i_virtualize_struct_stat
Also use consistent include order and naming in all files.
Fixes: 0ecaef5 ([sb2] Add gate for statx. JB#49501)
Signed-off-by: Björn Bidar <[email protected]>
include/elf.h:25:14: error: expected ‘;’ before ‘typedef’
25 | __BEGIN_DECLS
| ^
| ;
Fixes: 055cb96 (Incomplete OS X support)
Signed-off-by: Björn Bidar <[email protected]>
Fixes errors such as: include/rule_tree.h:22:9: error: unknown type name ‘uint32_t’ 22 | typedef uint32_t ruletree_object_offset_t; Signed-off-by: Björn Bidar <[email protected]>
preload/vperm_statfuncts.c:122:5: warning: no previous prototype for ‘i_virtualize_struct_stat_internal’ [-Wmissing-prototypes] 122 | int i_virtualize_struct_stat_internal( Signed-off-by: Björn Bidar <[email protected]>
Thaodan
force-pushed
the
no_multiarch_out_of_tree
branch
from
bbd5c5d
to
bb58b38
Compare
Previously in some instance the assumption was $(SRCDIR) = $(OBJDIR). If $(OBJDIR) isn't equal to $(SRCDIR) these files were not found anymore. Signed-off-by: Björn Bidar <[email protected]>
Resolves error when using a compiler with stricter settings such as when using LTO. Signed-off-by: Björn Bidar <[email protected]>
Both open and openat load their last argument 'mode' lazily, using va_arg() only if O_CREAT is found in oflag. This is wrong, mode is also necessary if O_TMPFILE is in oflag. Adapt __OPEN_NEEDS_MODE(oflag) present since glibc 2.22 to solve the issue. Read more down below: https://sourceware.org/git/?p=glibc.git;a=commit;h=65f6f938cd562a614a68e15d0581a34b177ec29d Signed-off-by: Björn Bidar <[email protected]>
Once in autogen.sh and once in %make Signed-off-by: Björn Bidar <[email protected]>
Signed-off-by: Björn Bidar <[email protected]>
Signed-off-by: Björn Bidar <[email protected]>
The builtin multilib support as unused. It's cleaner to built libsb2 for 32bit targets in a 32bit worker. The side effect of these changes is that make file pickup the correct directories passed to configure in %configure. Also now we can use regular build macros. Signed-off-by: Björn Bidar <[email protected]>
By detecting if configure.ac has changed and thus configure will change in the following step we can run autogen.sh and config.status to rerun configure with the previously set built options. The change removes the need for .configure file, correctly detects if configures sources changed and doesn't run configure again without all the previously passed options. Signed-off-by: Björn Bidar <[email protected]>
In case the root Makefile isn't in PWD assume that the Makefiles directory is the source directory. Signed-off-by: Björn Bidar <[email protected]>
Remove obsolete and unused things. Own all directories correctly (this will be an error in later RPM versions). Signed-off-by: Björn Bidar <[email protected]>
Remove useless checks like:
```
command
if [ $# -eq 0 ] ; then
error
fi
```
Or replace obsolescent -a and -o with `[ ] && [ ] ` and `[ ] || [ ]`.
https://github.com/koalaman/shellcheck/wiki/SC2166
https://github.com/koalaman/shellcheck/wiki/SC2181
Doing so exits with a clearer error message then errors about sb2d failing to start later such as these: Runtime-Error loading /tmp/sb2-bidar-20240329-145433.AwoNRb/lua_scripts/init.lua (...dar-20240329-145433.AwoNRb/lua_scripts/argvenvp_misc.lua:28: bad argument #1 to 'files' (/tmp/sb2-bidar-20240329-145433.AwoNRb/wrappers.sdk-build: No such file or directory)) sb2: Error: startup of sb2d failed. Tested-by: Björn Bidar <[email protected]>
To make it easier to detect where Scratchbox2 helper scripts and binaries are found on the host and partially on the tooling/target. This is especially important for helper binaries such as sb2dctl. Signed-off-by: Björn Bidar <[email protected]>
Thaodan
force-pushed
the
no_multiarch_out_of_tree
branch
from
bb58b38
to
b43cf32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove multilib for x86_64 and use autotools variables
d34c077
The builtin multilib support as unused. It's cleaner to built
libsb2 for 32bit targets in a 32bit worker.
The side effect of these changes is that make file pickup
the correct directories passed to configure in %configure.
Automatically detect out of tree builds
c73c772
In case the root Makefile isn't in PWD assume that the Makefiles
directory is the source directory.
Use autotools builtin system to rerun configure instead of our own
04f90b4
By detecting if configure.ac has changed and thus configure will change
in the following step we can run autogen.sh and config.status to rerun
configure with the previously set built options.
The change removes the need for .configure file, correctly detects
if configures sources changed and doesn't run configure again without
all the previously passed options.
Contains changes from #22 and #23.