Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the majority of the dependencies #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thefirstspine
Copy link

Description

This PR updates the majority of the dependencies. Only chalk was not updated due to ESM support within the lib.

Tests

Fixed tests with new mocha version which deprecated mocha.opts (moved to package.json).

$ npm run test

> [email protected] test
> npm run lint && npm run custom-tests


> [email protected] lint
> node ./node_modules/eslint/bin/eslint . --max-warnings=0 && echo '✔  Your code looks good.'

✔  Your code looks good.

> [email protected] custom-tests
> node ./node_modules/mocha/bin/mocha --recursive --timeout 10000 && echo "Custom tests all passed." && echo



  sanity
    require("sails-hook-grunt")
      ✔ should work
      ✔ should come back with a function


  2 passing (23ms)

Custom tests all passed.

@thefirstspine
Copy link
Author

thefirstspine commented Dec 23, 2023

Well, this upgrade requires Node >= 12.

@eashaw is Sails planned to drop support for Node 10 (which is 4 years old)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant