Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-50368 Discussions and Dropbox improve ui responsiveness #12792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SAK-50368 Discussions and Dropbox improve ui responsiveness #12792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
369aaf2
SAK-50368 Responsiveness of Discussions and Dropbox tools
Aug 14, 2024
293f0b8
SAK-50368 Responsiveness of Discussions and Dropbox tools
Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion content/content-tool/tool/src/webapp/vm/content/sakai_resources_list.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
vertical-align: middle !important;
text-align:left !important;
}
.table td{
text-indent: 0em !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand this change. where is a text-indent being applied?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "List of Dropboxes" table within the student view, there was an inline CSS code for text-indent: 1 em. I had to override that by adding !important. I have attached two screenshots with and without the text-indent for your reference.
W:o text-indent
With text-indent

.table .attach {
width:1%;
white-space:nowrap;
Expand All @@ -17,10 +20,13 @@
}
.truncate{
width: 180px;
white-space: nowrap;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}
.text-truncate{
white-space: normal !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Sharadhi98 is it possible to avoid using !important and rely on specificity?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that text-truncate is a bootstrap class. i don't think it makes sense to override Bootstrap like this. if you don't like the use of text-truncate, the use of the class should be removed/altered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment. I will go through the code and try to avoid !important.

}
.popover-content {
text-indent: 0;
}
Expand Down
2 changes: 1 addition & 1 deletion msgcntr/messageforums-app/src/webapp/jsp/dfCompose.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<h:outputText value="#{msgs.cdfm_info_required_sign}" styleClass="reqStar"/>
<h:outputText value="#{msgs.cdfm_title}"/>
</h:outputLabel>
<h:inputText value="#{ForumTool.composeTitle}" style="width:30em;" maxlength="250" required="true" id="df_compose_title" requiredMessage="#{msgs.cdfm_invalidMessageTitleString}">
<h:inputText value="#{ForumTool.composeTitle}" style="width:100%;" maxlength="250" required="true" id="df_compose_title" requiredMessage="#{msgs.cdfm_invalidMessageTitleString}">
<f:validator validatorId="MessageTitle" />
<f:validateLength minimum="1" maximum="255"/>
</h:inputText>
Expand Down
Loading