SAK-50134 Portal theme property for auto detecting dark mode should match documentation #12886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tches with documentation
ern
changed the title
ern
reviewed
Sep 16, 2024
| @@ -288,7 +288,7 @@ public void init(ServletConfig config) throws ServletException { | |||
| preferenceToolId = serverConfigurationService.getString("portal.preferencestool", "sakai.preferences"); | |||
| profileToolId = serverConfigurationService.getString("portal.profiletool", "sakai.profile2"); | |||
| sakaiThemeSwitcherEnabled = serverConfigurationService.getBoolean(PROP_PORTAL_THEMES_SWITCHER, true); | |||
| sakaiThemesAutoDetectDarkEnabled = serverConfigurationService.getBoolean(PROP_PORTAL_THEMES_AUTO_DARK, true); | |||
| sakaiThemesAutoDetectDarkEnabled = serverConfigurationService.getBoolean(PROP_PORTAL_THEMES_AUTO_DARK, false); | |||
There was a problem hiding this comment.
@jkjanetschek I think the docs should be adjusted to match the code
|
Do I understand you correctly, that you feel to change the comment in sakai.properties instead to Enable/disable the OS dark theme auto-detect modeDEFAULT: true |
|
Yes many applications these days follow the user's os setting when it comes to dark mode. |
change back to default PROP_PORTAL_THEMES_AUTO_DARK = true
change default.sakai.properties to match default value in code
ern
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tches with documentation