SAK-50438 Rubrics trigger event so that criteria get updated on a reorder #12927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
changed the title
ern
reviewed
Sep 30, 2024
| @@ -37,6 +37,9 @@ export class SakaiRubricCriteria extends RubricsElement { | |||
| this.querySelector(`[data-criterion-id="${e.detail.data.criterionId}"] .drag-handle`).focus(); | |||
| }); | |||
|
|
|||
| // Reordering doesn't really care about the weight changes, but the event does get the criteria to update in the parent rubric object | |||
There was a problem hiding this comment.
have you tried this.requestUpdate()
There was a problem hiding this comment.
I did, and it didn't work. I'm guessing because the "parent" doesn't know anything about the updated criteria?
There was a problem hiding this comment.
Let me poke at it again...
|
conflicts |
|
I see that you merged my other rubric PR, so I'll get this one updated to fix the conflicts, hopefully tonight. |
ern
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test