Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50622 Gradebook Tabulator Migration Fix Broken Buttons, Sorters, Dark Mode And Console Errors #12984

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

kunaljaykam
Copy link
Member

@kunaljaykam kunaljaykam commented Oct 24, 2024

@kunaljaykam kunaljaykam force-pushed the SAK-50622 branch 2 times, most recently from 966dd3d to d6b1d20 Compare October 24, 2024 15:52
@kunaljaykam kunaljaykam marked this pull request as ready for review October 24, 2024 15:53
@kunaljaykam kunaljaykam marked this pull request as draft October 25, 2024 09:11
@kunaljaykam kunaljaykam changed the title SAK-50622 Gradebook Tabulator Fix Broken Buttons and console errors SAK-50622 Gradebook Tabulator Migration Fix Broken Buttons, Sorters, Dark Mode And Console Errors Oct 26, 2024
@ottenhoff
Copy link
Contributor

Looking good. I see one problem with the "Sections" display (you must be in a site using sections, e.g., create new site as instructor1 when sakai.demo=true)

Screenshot 2024-10-28 at 11 00 10 AM

Copy link
Contributor

@ottenhoff ottenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@ern ern merged commit 2762abd into sakaiproject:master Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants