Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various updates #124

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Various updates #124

merged 1 commit into from
Nov 8, 2024

Conversation

papjul
Copy link
Contributor

@papjul papjul commented Nov 8, 2024 •
edited
Loading

  • Target SDK 35 and enable edge-to-edge support
  • Update all dependencies*
  • Remove "Download from Play Store" banner
  • Fix crash when entering settings when there are no translation entered in the textarea
  • Automatically allow only strictly necessary cookies to avoid the cookie popup
  • Optimize build
  • Add .debug suffix to the applicationId debug build to allow installing debug and release builds in parallel

*Gradle was updated and its checksum can be checked here: https://gradle.org/release-checksums/

@sakusaku3939
Copy link
Owner

@papjul Fantastic!!!
I would like to run it locally later and if there are no problems, I will work on the release. 🎉
I really appreciate the various fixes you have made.

sakusaku3939
sakusaku3939 reviewed Nov 8, 2024
View reviewed changes
Copy link
Owner

@sakusaku3939 sakusaku3939 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one point that I was wondering about and will add to the review.
Various changes are included and I may ask you for additional information when I check on the local of PC.

app/src/main/java/com/example/deeplviewer/activity/MainActivity.kt Outdated Show resolved Hide resolved
@papjul papjul requested a review from sakusaku3939 November 8, 2024 14:22
sakusaku3939
sakusaku3939 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Owner

@sakusaku3939 sakusaku3939 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like CI/CD is failing, but I will fix it on mine after the merge. Please wait for the release. 👍
Thank you for your support! LGTM

@sakusaku3939 sakusaku3939 merged commit 4f4266d into sakusaku3939:master Nov 8, 2024
1 check failed
@papjul
Copy link
Contributor Author

papjul commented Nov 8, 2024

Yes, the CI failure is unrelated to this PR, it's about the QSTileService

@papjul papjul deleted the update branch November 8, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakusaku3939 sakusaku3939 sakusaku3939 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@papjul @sakusaku3939