Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize PNG files #126

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Optimize PNG files #126

merged 1 commit into from
Nov 9, 2024

Conversation

papjul
Copy link
Contributor

@papjul papjul commented Nov 8, 2024

Optimize PNG files using oxipng -Z -o max --strip all.
Should make the APK slightly smaller without losing quality.

Note: the icon.png was actually a JPEG. So I replaced it with the other similar PNG file from the drawable directory.

Copy link
Owner

@sakusaku3939 sakusaku3939 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for optimizing the images! I didn't know that the fake .png I found in the past were still there...🫠

@sakusaku3939 sakusaku3939 merged commit 1163bed into sakusaku3939:master Nov 9, 2024
1 check passed
@sakusaku3939
Copy link
Owner

sakusaku3939 commented Nov 9, 2024

LGTM
@papjul Since this change has minimal impact on users, would it be alright to include it in the next irregularly scheduled release?

@papjul
Copy link
Contributor Author

papjul commented Nov 9, 2024

Yes, it's a minor change ;)

@sakusaku3939
Copy link
Owner

Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants