Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Location #35

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Resolve Location #35

merged 6 commits into from
Oct 30, 2023

Conversation

Tentanus
Copy link
Collaborator

  • Added resolveLocation method to ServerSettings class

@Tentanus Tentanus added the 💫enhancement New feature or request label Oct 30, 2023
saladuit
saladuit requested changes Oct 30, 2023
View reviewed changes
Copy link
Owner

@saladuit saladuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Perhaps we can already implement it after you made the final changes

include/ServerSettings.hpp Outdated Show resolved Hide resolved
src/ServerSettings.cpp Show resolved Hide resolved
src/ServerSettings.cpp Outdated Show resolved Hide resolved
@Tentanus
imporved printserversettings method
386a9dd 
changed typo in enum classe AlllowedMethods
added const &
@Tentanus
removed redundant header
76c5c56
Tentanus
Tentanus commented Oct 30, 2023
View reviewed changes
Copy link
Collaborator Author

@Tentanus Tentanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finshed, all comments resolved

saladuit
saladuit approved these changes Oct 30, 2023
View reviewed changes
Copy link
Owner

@saladuit saladuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@saladuit saladuit merged commit 582c930 into main Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saladuit saladuit saladuit approved these changes

Assignees

@saladuit saladuit

@Tentanus Tentanus

Labels
💫enhancement New feature or request
Projects
BuzingaServ
Status: ✅Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tentanus @saladuit