-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configsyntax #37
Configsyntax #37
Conversation
…isely... a problem for tomorrow
…ity, just trying to keep it simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some small things, but generally I'm proud of your growth in your cpp coding. It is very readable and well structured. I applaud your progress! Please take a look at my comments. All question marks are genuine questions that I couldn't figure out from just reading it. Lastly, You're doing well with throwing errors, The only thing I'm missing is the way you want to handle it. If you wan't to exit the program with all of your runtime error's you should leave it as is. (only change the mesaging a bit). If you do want to continue, (for example when a directive is overwritten, consider making a "DuplicateEntryException" class, so that you can catch it gracefully, log the warning and continue parsing, It is up to you though!
…size, servername; Locationblock: index, alias
…S in Serversettings/LocationSettings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good usage of the overwriting warnings!
I've written a small syntax checker for the configfile.
It checks for the following:
TO DO