Configimplementation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l needs to be implemented
…bug in Error pages;
…w ReturnException. WIP: still need to edit Client Class and generate correct response
saladuit
requested changes
Mar 28, 2024
lucienvb
reviewed
Apr 1, 2024
lucienvb
reviewed
Apr 1, 2024
saladuit
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Ik vind het lastig om hier nog eens door heen te gaan. In het vervolg protip. Als je zo'n grote pr maakt zorg dan dat je zoveel mogelijk extra info toevogd. Zoals 'hier ben ik niet zo zeker omdat, zus en zo' of 'dit zijn de belangrijke onderdelen waar ik nog deze vragen over heb'. Op die manier maak je het ook behapbaarder voor de gene die dingen nog na gaat. Ik ga hem voor nu gewoon approven en we zijn bij de eval wel wat er nog mis gaat
…ed where it's failing
Tentanus
commented
Apr 28, 2024
saladuit
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented configfile.
The project still needs work on the listen directive. especially thinking about what ports are being used.