Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDK license compliance #1192

Open
wants to merge 1 commit into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Open

Fix SDK license compliance #1192

wants to merge 1 commit into from

Conversation

gugalo
Copy link
Collaborator

@gugalo gugalo commented Dec 18, 2024

Jira issue:
https://glia.atlassian.net/browse/MOB-3835

What was solved?
Renamed LICENSE file to LICENSE.txt to fix link in old maven releases that have hardcoded link to license in POM file.

Added license file in the src/main/assets directory. By adding it there it will be included in the AAR’s assets folder. While placing the license at the root of the AAR might have made it more visible, this approach still ensures that the license is packaged with the library, easily accessible to consumers, and compliant with licensing requirements—all without the need for post-processing the AAR through custom Gradle scripts.

The main minus of this solution is that now there are two copies of license file in the same project making it easy to miss in later changes.

Release notes:

  • Feature: This improves the visibility of our license but not sure if this should be mentioned in changelog
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@gugalo gugalo requested a review from a team as a code owner December 18, 2024 15:17
@andrews-moc andrews-moc force-pushed the feature/entry-widget-and-secure-conversations-v2 branch 2 times, most recently from 2ca729a to 35d6916 Compare December 27, 2024 15:56
@gugalo gugalo force-pushed the feature/MOB-3835 branch 2 times, most recently from 84589c2 to 1acf03e Compare January 6, 2025 06:33
@gugalo
Fix SDK license compliance
d650085 
Renamed `LICENSE` file to `LICENSE.txt` to fix link in old maven releases that have hardcoded link to license in POM file.

Added license file in the src/main/assets directory. By adding it there it will be included in the AAR’s assets folder. While placing the license at the root of the AAR might have made it more visible, this approach still ensures that the license is packaged with the library, easily accessible to consumers, and compliant with licensing requirements—all without the need for post-processing the AAR through custom Gradle scripts.

The main minus of this solution is that now there are two copies of license file in the same project making it easy to miss in later changes.

MOB-3835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrews-moc andrews-moc andrews-moc approved these changes

@Pelkar Pelkar Awaiting requested review from Pelkar

@AH-MOC AH-MOC Awaiting requested review from AH-MOC

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gugalo @andrews-moc