Fix engagement started on the chat screen #1194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AH-MOC
force-pushed
the
MOB-3888_fix_engagement_started
branch
from
08c9ae4 to
8e928ad
Compare
AH-MOC
force-pushed
the
MOB-3888_fix_engagement_started
branch
from
8e928ad to
0eb5075
Compare
andrews-moc
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
ae3c8f4 to
274f4c5
Compare
|
@AndriiHorishniiMOC, could you please rebase this branch? |
- Migrate Call and Chat Activities to Kotlin - Refactor CallConfiguration - Refactor EngagementConfiguration MOB 3587
- Moved all the Intent-related functionality to the IntentHelper class. - Abstraction will let us to easily mock this layer. MOB 3582
- Create ActivityLauncher - Rename FilePreview... classes to ImagePreview... MOB 3589
- Create interfaces for EngagementLauncher - Create basic ConfigurationManager that should hold all the init config MOB 3588
This custom attributes can be setup by integrators in their theme.xml
This is needed so that customise glia theme settings in integrators theme.xml
- Remove all the configurations in favor of ConfigurationManager - Get rid of configurations passed through Activity extras - Move extra keys to internal class - Make activities internal - Minor refactoring
Texts have changed, updating according to the Figma designs. MOB-3615
…idget Setup queues each time get Entry Widget is called MOB-3408
…g to design MOB-3478
Side effect of making the layout flat is that now those buttons have slight animation. MOB-3844
Last Core SDK staging build got expired/deleted so uploaded new build
- Added inputDisabled Json to UI remote theme configurations - Switched simple color/drawables to ColorStateList/DrawableStateList MOB-3855
Remove SecureFileAttachmentRepository and some SC use cases that duplicated the logic. Refactor FileAttachmentRepository and the file upload use cases. FileAttachmentRepository is used for both SC and Live Engagement. MOB-3791
Issue introduced in #1183
Do not start a timer for marking messages as read if the leave secure conversation dialog is shown. MOB-3833
…type or starts a new engagement during queueing MOB-3886
andrews-moc
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
2ca729a to
35d6916
Compare
When the chat screen opens with the secure conversation state, resubscribe to the engagement streams. This solves the upgrade to chat state issue. MOB-3888
andrews-moc
force-pushed
the
MOB-3888_fix_engagement_started
branch
from
0eb5075 to
555bca8
Compare
@DavDo I've rebased it ✅ |
gugalo
approved these changes
Jan 7, 2025
| @@ -258,6 +259,10 @@ internal class ChatController( | |||
| emitViewState { chatState.initChat().setSecureMessagingState() } | |||
| ensureSecureMessagingAvailable() | |||
| observeTopBannerUseCase() | |||
|
|
|||
| // When the chat screen opens with the secure conversation state, resubscribe to the engagement streams. | |||
| // This solves the upgrade to chat state issue. | |||
There was a problem hiding this comment.
Please also add a Jira bug ticket number here. In case someone in the future decides to refactor any related code so that they have reference to find initial steps to make sure that issue didn't re-surface
andrews-moc
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
ea158b2 to
705f15e
Compare
|
Closing because this was fixed in #1210, and our principle is to decide the chat state before opening the screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-3888
What was solved?
When the chat screen opens with the secure conversation state, resubscribe to the engagement streams. This solves the upgrade to chat state issue.
Release notes:
Additional info:
Screenshots: