-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if live engagement is when SC Intention #1199
Closed
AH-MOC
wants to merge
109
commits into
feature/entry-widget-and-secure-conversations-v2
from
MOB-3888_check_live_engagement
Closed
Check if live engagement is when SC Intention #1199
AH-MOC
wants to merge
109
commits into
feature/entry-widget-and-secure-conversations-v2
from
MOB-3888_check_live_engagement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate Call and Chat Activities to Kotlin - Refactor CallConfiguration - Refactor EngagementConfiguration MOB 3587
- Moved all the Intent-related functionality to the IntentHelper class. - Abstraction will let us to easily mock this layer. MOB 3582
- Create ActivityLauncher - Rename FilePreview... classes to ImagePreview... MOB 3589
- Create interfaces for EngagementLauncher - Create basic ConfigurationManager that should hold all the init config MOB 3588
This custom attributes can be setup by integrators in their theme.xml
This is needed so that customise glia theme settings in integrators theme.xml
- Remove all the configurations in favor of ConfigurationManager - Get rid of configurations passed through Activity extras - Move extra keys to internal class - Make activities internal - Minor refactoring
Texts have changed, updating according to the Figma designs. MOB-3615
…idget Setup queues each time get Entry Widget is called MOB-3408
…g to design MOB-3478
…led in Example App settings MOB-3657
…is not authenticated MOB-3659
…t queues should be used MOB-3657
This change is directly related to changes in Core SDK regarding OkHttp version. See salemove/android-sdk#763 MOB-3661
These changes are to make secure conversations align with new UI designs. Part of Secure Conversations V2 project. MOB-3621
MOB-3845
Side effect of making the layout flat is that now those buttons have slight animation. MOB-3844
Last Core SDK staging build got expired/deleted so uploaded new build
- Added inputDisabled Json to UI remote theme configurations - Switched simple color/drawables to ColorStateList/DrawableStateList MOB-3855
Remove SecureFileAttachmentRepository and some SC use cases that duplicated the logic. Refactor FileAttachmentRepository and the file upload use cases. FileAttachmentRepository is used for both SC and Live Engagement. MOB-3791
Issue introduced in #1183
Do not start a timer for marking messages as read if the leave secure conversation dialog is shown. MOB-3833
…type or starts a new engagement during queueing MOB-3886
DavDo
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking merge just in case, until we decide this.
andrews-moc
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
January 13, 2025 15:40
ea158b2
to
705f15e
Compare
Closing because this was fixed in #1210, and our principle is to decide the chat state before opening the screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-3888
What was solved?
Check if live engagement is when SC Intention.
Release notes:
Additional info:
Screenshots: