Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix send and attachment buttons overlap #1204

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix send and attachment buttons overlap #1204

wants to merge 2 commits into from

Conversation

Andrii-Horishnii-Glia
Copy link

Jira issue:
https://glia.atlassian.net/browse/MOB-3844

Cherry-pick from the feature/entry-widget-and-secure-conversations-v2 branch.

What was solved?
Fix send and attachment buttons overlap.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@Andrii-Horishnii-Glia Andrii-Horishnii-Glia requested a review from a team as a code owner January 8, 2025 21:09
@Andrii-Horishnii-Glia Andrii-Horishnii-Glia changed the base branch from master to development January 8, 2025 21:09
andrews-moc
andrews-moc reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@andrews-moc andrews-moc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this thread, looks like this commit should also be included, am I right?

@DavDo
Copy link
Collaborator

DavDo commented Jan 9, 2025

Based on this thread, looks like this commit should also be included, am I right?

I think it's impossible because that commit also includes SC top and bottom banners.

@Andrii-Horishnii-Glia
Copy link
Author

@DavDo But partially, it is possible. I apply changes to the chat_view.xml.

gugalo added 2 commits January 9, 2025 17:04
@gugalo @Andrii-Horishnii-Glia
Fix send and attachment buttons overlap
2f4ca06 
Side effect of making the layout flat is that now those buttons have slight animation.

MOB-3844

# Conflicts:
#	build.gradle
#	widgetssdk/src/main/java/com/glia/widgets/chat/ChatView.kt
#	widgetssdk/src/main/res/layout/chat_view.xml
@gugalo @Andrii-Horishnii-Glia
Fix jumpy animation of chat input on keyboard show/hide
b3b8c10 
MOB-3860

# Conflicts:
#	widgetssdk/src/main/java/com/glia/widgets/chat/ChatView.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrews-moc andrews-moc andrews-moc approved these changes

@DavDo DavDo DavDo approved these changes

@gugalo gugalo gugalo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andrii-Horishnii-Glia @DavDo @gugalo @andrews-moc