Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions which are older than 1 year #1205

Open
wants to merge 1 commit into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from

Conversation

andrews-moc
Copy link
Contributor

@andrews-moc andrews-moc commented Jan 9, 2025

⚠️ Bitrise is failing because Core SDK release with updated Authentication.java is required.

What was solved?
[Android] Developers want to remove deprecated functions which are older than 1 year

Release notes:
Remove deprecated functions and resources which are older than 1 year

Migration guide:

Before After
Authentication.kt
authenticate(requestCallback: RequestCallback<Void>, jwtToken: String) authenticate(jwtToken: String, externalAccessToken: String?, requestCallback: RequestCallback<Void>)
CustomCardAdapter.java
isInteractable(ChatMessage message, int viewType) Nothing. The result of isInteractable() did not affect the behavior of the input field. The chat input field was always active anyway.
colors.xml
R.color.glia_transparent_black_buttons_bg R.color.glia_call_control_buttons_color
R.color.glia_transparent_black_bg R.color.glia_call_view_background_color
  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKsThings to consider for newly added logs in Confluence for more information.

@andrews-moc andrews-moc requested a review from a team as a code owner January 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants