Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat to Secure Conversation transfer #1110

Open
wants to merge 1 commit into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Open

Chat to Secure Conversation transfer #1110

wants to merge 1 commit into from
+60 −12

Conversation

EgorovEI
Copy link
Contributor

@EgorovEI EgorovEI commented Nov 8, 2024

MOB-3630

What was solved?
This PR introduces handling Live chat to Secure Conversations transferring

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

@EgorovEI EgorovEI changed the title Chat to Secure Conversation transfer [HOLD] Chat to Secure Conversation transfer Nov 8, 2024
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from ea35791 to 1ea3ecf Compare November 11, 2024 13:22
@EgorovEI EgorovEI force-pushed the task/MOB-3630-gva-to-secure-conversations-transfer branch from 76c7e86 to fb5e245 Compare November 11, 2024 13:24
@EgorovEI EgorovEI marked this pull request as ready for review November 11, 2024 13:26
@EgorovEI EgorovEI changed the title [HOLD] Chat to Secure Conversation transfer Chat to Secure Conversation transfer Nov 11, 2024
@EgorovEI EgorovEI force-pushed the task/MOB-3630-gva-to-secure-conversations-transfer branch from fb5e245 to 4828b50 Compare November 12, 2024 10:35
@EgorovEI
Copy link
Contributor Author

!squash

Chat to Secure Conversation transfer
dbe45bf 
This commit introduces handling Live chat to Secure Conversations transferring

MOB-3630
@sm-deployer sm-deployer force-pushed the task/MOB-3630-gva-to-secure-conversations-transfer branch from c423901 to dbe45bf Compare November 12, 2024 10:55
igorkravchenko
igorkravchenko approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left one question regarding added log.

GliaWidgets/Sources/Interactor/Interactor.swift
@@ -289,7 +290,13 @@ extension Interactor: CoreSdkClient.Interactable {
}

var onLiveToSecureConversationsEngagementTransferring: CoreSdkClient.EngagementTransferringBlock {
return {}
return { [weak self, environment] in
environment.log.prefixed(Self.self).info(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm if this newly introduced log is added to logging table as suggested in guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@ykyivskyi-gl ykyivskyi-gl Awaiting requested review from ykyivskyi-gl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorovEI @igorkravchenko @rasmustautsglia