Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump meriyah to v6 [BREAKING CHANGE] #5035

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nolanlawson
Copy link
Collaborator

@nolanlawson nolanlawson commented Dec 11, 2024

Details

BREAKING CHANGE: meriyah v6 drops support for Node <v18.

Relies on:

Previous revert:

Does this pull request introduce a breaking change?

  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner December 11, 2024 00:41
@nolanlawson nolanlawson added this to the 9.0.0 milestone Dec 11, 2024
@nolanlawson nolanlawson changed the title chore: bump meriyah to v6 chore: bump meriyah to v6 [BREAKING CHANGE] Dec 11, 2024
@wjhsf
Copy link
Contributor

wjhsf commented Dec 16, 2024

Might be helpful to bump the engines in this PR as a signal and/or merge conflict for ourselves later, so that we remember to do the bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants