Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): fix rendering of class with scope token #5072

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

nolanlawson
Copy link
Collaborator

Details

This looks like our last fix for scope tokens. We need to correctly combine the existing class attribute value with the scope token.

Does this pull request introduce a breaking change?

  • ๐Ÿ˜ฎโ€๐Ÿ’จ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ๐Ÿคž No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner December 20, 2024 17:41
@nolanlawson nolanlawson requested a review from wjhsf January 8, 2025 18:50
@nolanlawson nolanlawson merged commit fb5ef00 into master Jan 8, 2025
11 checks passed
@nolanlawson nolanlawson deleted the nolan/class-fix branch January 8, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants