Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v8.12.2 @W-17485572 #5078

Merged
merged 18 commits into from
Dec 20, 2024
Merged

chore: release v8.12.2 @W-17485572 #5078

merged 18 commits into from
Dec 20, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Dec 20, 2024

Details

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

nolanlawson and others added 18 commits December 16, 2024 12:55
@nolanlawson
test(ssr): add tests for nested elements in slots (#5048)
c4218fc
@nolanlawson
fix(compiler): log warning for missing name/namespace (#4825)
5d1837b
@nolanlawson
test(karma): remove unnecessary IE11-related code (#5054)
158f7e6
@jhefferman-sfdc
fix: replace barrel exports from lwc with @lwc/ssr-runtime (#5034)
a33b390 
* fix: replace barrel from `lwc` package with '@lwc/ssr-runtime'

* fix: handle * barrel case and corresponding tests

* fix: function naming

* fix: barrel import test parity

* fix: include optional exported alias for export all declaration replacement, tests

* chore: explain function name massaging in test

* fix: deep clone objects and optimize tests

* fix: remove unused shared file
@nolanlawson
test(karma): add test for for:each issue #4889 (#5053)
c5c7458
@cardoso @nolanlawson
fix(ssr): missing bookends for slotted lwc:if not at the top-level (#…
bcd22de 
…5027)

Co-authored-by: Nolan Lawson <[email protected]>
@nolanlawson @wjhsf
fix(ssr): fix HTML comment bookends for if blocks (#5055)
dbce15f 
Co-authored-by: Will Harney <[email protected]>
@cardoso
fix(ssr-compiler): namespace and name should be optional in Component…
57c1bd0 
…TransformOptions (#5058)
@nolanlawson
test(ssr): test if with adjacent text (#5056)
59e2c6c
@nolanlawson
test(karma): reduce #4889 even further (#5060)
063cc72
@nolanlawson
fix(ssr): fix style attribute rendering (#5061)
600c33e
@cardoso @wjhsf
fix(ssr-compiler): harmonize some wire errors (#5062)
141ac4d 
Co-authored-by: Will Harney <[email protected]>
@wjhsf
fix: only call callback when needed @W-17420330 (#5064)
ff0d118 
* fix: only call callback when needed @W-17420330

* chore: simplify test

* fix: use correct class check
@cardoso @nolanlawson
fix(ssr): render from superclass (#5063)
a6e321c 
Co-authored-by: Nolan Lawson <[email protected]>
@nolanlawson
test(ssr): add more superclass tests (#5065)
a971395
@wjhsf
fix: use correct shadow root @W-17441501 (#5070)
c477d4b 
* fix: use correct shadow root @W-17441501

* chore: yagni i guess

* chore: 🛩️📦

* If you read this, tell me so!
@ekashida
fix(ssr): align csr and ssr reflective behavior (#5050)
593da92
@wjhsf
chore: release v8.12.2 @W-17485572 (#5075)
c0c2253
@wjhsf wjhsf requested a review from a team as a code owner December 20, 2024 21:46
@wjhsf wjhsf enabled auto-merge (squash) December 20, 2024 21:47
@wjhsf
Copy link
Contributor Author

wjhsf commented Dec 20, 2024

/nucleus release

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • ✅ Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • ❌ Check PR is approved
    PR 5078 must be approved by at least one approver
  • ✅ Check PR is mergeable
    PR 5078 is mergeable
  • ✅ Check GUS reference is present
    GUS Work Item @W-17485572 parsed from PR title
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@wjhsf wjhsf merged commit 839c8bf into release Dec 20, 2024
20 of 22 checks passed
@wjhsf wjhsf deleted the wjh/release-20241220-release branch December 20, 2024 22:18
@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

✅ All Pre-release Checks Passed

  • ⚪️ Check PR user has rights to execute the workflow (skipped)
    Skipping PR owner check since PR has already been merged.
  • ✅ Check PR is approved
    PR 5078 is approved
  • ⚪️ Check PR is mergeable (skipped)
    PR 5078 has already been merged
  • ✅ Check GUS reference is present
    GUS Work Item @W-17485572 parsed from PR title
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

🚢 Release Starting

This pull request has been merged and the release of version 8.12.2 is starting.

You can monitor the progress of the release in Nucleus by visiting the following URL.
https://nucleus.uipengsys-public.buildndeliver-s.aws-esvc1-useast2.aws.sfdc.cl/workflows/257212

@jhefferman-sfdc
Copy link
Contributor

/nucleus release

@nolanlawson nolanlawson mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhefferman-sfdc jhefferman-sfdc jhefferman-sfdc approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjhsf @jhefferman-sfdc @nolanlawson @cardoso @ekashida