feat(contributing): add SFTP configuration #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnijdam
force-pushed
the
feature/jn/add-sftp
branch
5 times, most recently
from
fc63c80
to
a38031d
Compare
jnijdam
force-pushed
the
feature/jn/add-sftp
branch
6 times, most recently
from
4f610b3
to
d9407e4
Compare
daks
reviewed
Apr 6, 2022
There was a problem hiding this comment.
I made several comments to the code.
As noted, for now this code makes a breaking change because sftp module is activated which it was not previously.
Another problem is, when activating the sftp state (in kitchen.yml) converge do not pass. I think kitchen/inspec tests should be added to be confident in how this code works. See kitchen.yml suite section to add one to the default one.
jnijdam
force-pushed
the
feature/jn/add-sftp
branch
16 times, most recently
from
2da6cf2
to
55abc2c
Compare
jnijdam
force-pushed
the
feature/jn/add-sftp
branch
14 times, most recently
from
b5bceba
to
a8dac01
Compare
jnijdam
force-pushed
the
feature/jn/add-sftp
branch
6 times, most recently
from
2ff6369
to
cdf905f
Compare
daks
force-pushed
the
feature/jn/add-sftp
branch
2 times, most recently
from
2211721
to
777d0c8
Compare
daks
force-pushed
the
feature/jn/add-sftp
branch
from
777d0c8
to
2e02699
Compare
|
@jnijdam I'm working on improving your PR which is not functional right now. I'll add commits to it once I get a working setup |
daks
force-pushed
the
feature/jn/add-sftp
branch
from
f502ed5
to
0839c9f
Compare
daks
force-pushed
the
feature/jn/add-sftp
branch
from
0839c9f
to
8d95d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[feat]A new featureSecondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).Testing checklist
state_top).Additional context