Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup old information in the README.rst file #1955

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

cleanup old information in the README.rst file

@ITJamie
Copy link
Contributor

ITJamie commented Aug 2, 2023

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@s0undt3ch
Copy link
Contributor

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

@ITJamie
Copy link
Contributor

ITJamie commented Aug 2, 2023

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst.
a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

@s0undt3ch
Copy link
Contributor

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst. a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

Well, that does sound like a suggestion that is not impossible to implement.

@garethgreenaway thoughts?

README.rst Outdated Show resolved Hide resolved
@garethgreenaway
Copy link
Contributor Author

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst. a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

Well, that does sound like a suggestion that is not impossible to implement.

@garethgreenaway thoughts?

@s0undt3ch Woks for me.

@s0undt3ch
Copy link
Contributor

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst. a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

Well, that does sound like a suggestion that is not impossible to implement.
@garethgreenaway thoughts?

@s0undt3ch Woks for me.

@ITJamie if you want to take a stab at it, we would be happy to review it.

@s0undt3ch s0undt3ch enabled auto-merge (rebase) August 9, 2023 16:13
@s0undt3ch s0undt3ch merged commit 61709aa into develop Aug 11, 2023
411 of 412 checks passed
@s0undt3ch s0undt3ch deleted the readme_cleanup branch August 11, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants