Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tempos and time signatures in MIDI output #13

Open
salu133445 opened this issue Jan 7, 2021 · 1 comment
Open

Support tempos and time signatures in MIDI output #13

salu133445 opened this issue Jan 7, 2021 · 1 comment

Comments

@salu133445
Copy link
Owner

The current implementation of to_pretty_midi does not support tempos and time signatures. We should convert the tempo array into tempo change events and the downbeat array into time signature events.
George-Ogden added a commit to George-Ogden/pypianoroll that referenced this issue Jun 15, 2022
@George-Ogden
added algorithm to save tempo changes (salu133445#13)
8eca0fe
@George-Ogden
Copy link
Contributor

I've got the tempo array working but for time signatures (and key signatures), I think we need to save these as attributes of the multitrack and then read and write them in a similar way to the tempo.

@George-Ogden George-Ogden mentioned this issue Jul 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@salu133445 @George-Ogden