Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tempo Changes to pretty midi #24

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Added Tempo Changes to pretty midi #24

wants to merge 23 commits into from

Conversation

George-Ogden
Copy link
Contributor

Hi,

  • I've made a few changes to the repository to preserve tempo changes when saving. To do this, I've modified the to_pretty_midi function using some of the code directly from pretty-midi to add tempo changes using ticks.
  • I also modified the load function as this wasn't saving the tempi to the array correctly.
  • I updated references to np.bool to bool to be compatible with new versions of numpy
  • I tried to format and update the documentation but I'm not sure that worked.

@George-Ogden
Copy link
Contributor Author

I've now added information about time signatures. It's not perfect but will work in the majority of cases (#13).

@George-Ogden
Copy link
Contributor Author

will fix #19 as well as allowing integer/float values for Multitrack.tempo rather than np.array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@George-Ogden