🤖 Merge PR DefinitelyTyped#70913 [sharedb] add new doNotCommitNoOps…

… backend option and `agent.protocol` by @alecgibson
samantharamon · Oct 23, 2024 · 0620f0c · 0620f0c
1 parent ab6216c
commit 0620f0c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/types/sharedb/index.d.ts b/types/sharedb/index.d.ts
@@ -109,6 +109,7 @@ declare namespace sharedb {
         suppressPublish?: boolean;
         maxSubmitRetries?: number;
         doNotForwardSendPresenceErrorsToClient?: boolean;
+        doNotCommitNoOps?: boolean;
         errorHandler?: ErrorHandler;
 
         presence?: boolean;

diff --git a/types/sharedb/lib/agent.d.ts b/types/sharedb/lib/agent.d.ts
@@ -35,6 +35,10 @@ declare class Agent<TCustom = any> {
     clientId: string;
     src: string;
     connectTime: number;
+    protocol: {
+        major: number;
+        minor: number;
+    };
 
     /**
      * Sends a JSON-compatible message to the client for this agent.

diff --git a/types/sharedb/package.json b/types/sharedb/package.json
@@ -1,7 +1,7 @@
 {
     "private": true,
     "name": "@types/sharedb",
-    "version": "3.3.9999",
+    "version": "5.1.9999",
     "projects": [
         "https://github.com/share/sharedb"
     ],

diff --git a/types/sharedb/sharedb-tests.ts b/types/sharedb/sharedb-tests.ts
@@ -63,6 +63,7 @@ const options: ShareDB.ShareDBOptions = {
     milestoneDb: new MyMilestoneDB(),
     suppressPublish: false,
     maxSubmitRetries: 3,
+    doNotCommitNoOps: true,
     errorHandler: (error, context) => {
         console.log(error, context.agent.custom);
     },
@@ -156,6 +157,8 @@ backend.use("connect", (context, callback) => {
         context.backend,
         context.stream,
         context.req,
+        context.agent.protocol.major,
+        context.agent.protocol.minor,
     );
     callback();
 });