Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat yaml files to remove yamllint warnings #149

Merged
merged 11 commits into from
Jul 20, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

The title says it all. Tedious but straightforward. Gets rid of the noise when running make check-yaml so you can more easily see if you've introduced an error or warning.
I disagree with yaml lint on certain trailing comments, but I just went with the flow for now.

Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As we are already doing those cleanups, I would also recommend adding re-format to github's action yaml:

yq eval --inplace .github/workflows/container-image.yml

@mergify mergify bot merged commit 543fc17 into samba-in-kubernetes:master Jul 20, 2023
31 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-yaml-formatting branch July 21, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants