Expose CephFS snapshots as shadow-copies #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhernandez
reviewed
Jun 7, 2024
Shwetha-Acharya
force-pushed
the
snapshot-in-ceph
branch
2 times, most recently
from
018fbea to
99b7b03
Compare
|
/retest all |
|
/retest centos-ci/cephfs |
2 similar comments
|
/retest centos-ci/cephfs |
|
/retest centos-ci/cephfs |
Shwetha-Acharya
force-pushed
the
snapshot-in-ceph
branch
3 times, most recently
from
437cb8d to
8888df7
Compare
|
/retest all |
anoopcs9
reviewed
Jun 26, 2024
Shwetha-Acharya
force-pushed
the
snapshot-in-ceph
branch
from
8888df7 to
f1e8415
Compare
xhernandez
previously approved these changes
Jun 27, 2024
anoopcs9
requested changes
Jun 27, 2024
yes, that can be done if required |
Shwetha-Acharya
force-pushed
the
snapshot-in-ceph
branch
2 times, most recently
from
85b43f1 to
d721875
Compare
anoopcs9
requested changes
Jun 28, 2024
create shadow copy with the help of ceph_snapshots module: - use kernel CephFS mounted share path for cephfs - use absolute path within the Ceph filesystem for cephfs.vfs Refer: https://www.samba.org/samba/docs/4.11/man-html/vfs_ceph_snapshots.8.html Signed-off-by: Shwetha K Acharya <[email protected]>
Shwetha-Acharya
force-pushed
the
snapshot-in-ceph
branch
from
d721875 to
24ee881
Compare
xhernandez
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use kernel CephFS mounted share path to create the shadow copy using ceph_snapshots module
Refer: https://www.samba.org/samba/docs/4.11/man-html/vfs_ceph_snapshots.8.html