Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: Add optional method to use RADOS helper to manage cluster lock #107

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

anoopcs9
Copy link
Collaborator

It has been a while since a dedicated helper got added to CTDB for managing cluster locks directly on ceph RADOS. Therefore provide a mechanism to optionally configure it instead of the default shared file system locks.

See man ctdb_mutex_ceph_rados_helper(7) for more details.

@anoopcs9 anoopcs9 force-pushed the add-ctdb-ceph-rados-helper branch from 0c89638 to eb0a4c2 Compare June 13, 2024 10:11
In order to make use of alternate ways to manage ctdb cluster lock we
put the traditional method of holding it inside a shared file system
behind a conditional which can be optionally specified in settings yaml.

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9 anoopcs9 force-pushed the add-ctdb-ceph-rados-helper branch 3 times, most recently from fe7c040 to caddc4e Compare June 14, 2024 09:59
anoopcs9 added 2 commits June 14, 2024 16:01
With cephfs.data.ctdb_mutex set to 'rados' we make use of dedicated
ctdb_mutex_ceph_rados_helper binary to manage cluster lock.

See manual page[1] for more details.

[1] https://ctdb.samba.org/manpages/ctdb_mutex_ceph_rados_helper.7.html

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9 anoopcs9 force-pushed the add-ctdb-ceph-rados-helper branch from caddc4e to 4322ec7 Compare June 14, 2024 10:41
@anoopcs9 anoopcs9 marked this pull request as ready for review June 14, 2024 11:13
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good in general, but I am wondering if we can make rados the default ctdb mutex helper only in the ceph case.

Approving nonetheless since we could change this later.

@obnoxxx obnoxxx merged commit af23b53 into samba-in-kubernetes:main Jun 14, 2024
9 checks passed
@anoopcs9 anoopcs9 deleted the add-ctdb-ceph-rados-helper branch June 14, 2024 17:25
@anoopcs9
Copy link
Collaborator Author

This looks very good in general, but I am wondering if we can make rados the default ctdb mutex helper only in the ceph case.

That is already the case. config.data.ctdb_mutex is only defined for cephfs backend in playbooks/settings.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants