Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smbtorture: Add all the smb2.* tests to smbtorture #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

smbtorture: Add all the smb2.* tests to smbtorture #65

wants to merge 1 commit into from

Conversation

spuiuk
Copy link
Collaborator

@spuiuk spuiuk commented Feb 7, 2024

Add to the list of the smbtorture tests run.

@spuiuk
Copy link
Collaborator Author

spuiuk commented Feb 7, 2024

Setting do-not-merge for now - Just want to run it through the CI to see the list of failing tests for xfs.

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Feb 8, 2024

Add to the list of the smbtorture tests run.

As you can see(test timed out after 6h 😕 ) may be it is not a good idea to enable all at once.

@spuiuk spuiuk force-pushed the smbtorture_tests branch from 6b9b07c to 40198dc Compare March 7, 2024 19:10
@spuiuk
Copy link
Collaborator Author

spuiuk commented Mar 11, 2024

/retest all

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Mar 11, 2024 •
edited
Loading

For smb2.maxfid:

_______________ test_smbtorture[share-gpfs-default-smb2.maxfid] ________________

share_name = 'share-gpfs-default', test = 'smb2.maxfid'

    @pytest.mark.timeout(90)
    @pytest.mark.parametrize("share_name,test", generate_smbtorture_tests())
    def test_smbtorture(share_name: str, test: str) -> None:
        output = testhelper.get_tmp_file()
>       ret = smbtorture(share_name, test, output)

testcases/smbtorture/test_smbtorture.py:128: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
testcases/smbtorture/test_smbtorture.py:82: in smbtorture
    filter_subunitc.communicate()
/usr/lib64/python3.9/subprocess.py:1126: in communicate
    self.wait()
/usr/lib64/python3.9/subprocess.py:1189: in wait
    return self._wait(timeout=timeout)
/usr/lib64/python3.9/subprocess.py:1933: in _wait
    (pid, sts) = self._try_wait(0)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <Popen: returncode: None args: ['/usr/bin/python3', '/root/sit-test-cases/te...>
wait_flags = 0

    def _try_wait(self, wait_flags):
        """All callers to this function MUST hold self._waitpid_lock."""
        try:
>           (pid, sts) = os.waitpid(self.pid, wait_flags)
E           Failed: Timeout >90.0s

/usr/lib64/python3.9/subprocess.py:1891: Failed

@spuiuk
Copy link
Collaborator Author

spuiuk commented Mar 11, 2024 •
edited
Loading

With the following additional tests

  • smb2.durable-v2-delay
  • smb2.durable-v2-open
  • smb2.maxfid
  • smb2.async_dosmode
  • smb2.create_no_streams
  • smb2.timestamps
  • smb2.bench
  • smb2.winattr2
  • smb2.charset

List of failures:

xfs: None

cephfs:
samba3.smb2.timestamps.time_t_15032385535
samba3.smb2.timestamps.time_t_10000000000
samba3.smb2.timestamps.time_t_-1
samba3.smb2.timestamps.time_t_-2
samba3.smb2.timestamps.time_t_1968
timeouts for share-cephfs-default-smb2.compound_find and share-cephfs-default-smb2.maxfid

cephfs.vfs:
samba3.smb2.timestamps.time_t_15032385535
samba3.smb2.timestamps.time_t_10000000000
samba3.smb2.timestamps.time_t_4294967295
samba3.smb2.timestamps.time_t_1
samba3.smb2.timestamps.time_t_0
samba3.smb2.timestamps.time_t_-1
samba3.smb2.timestamps.time_t_-2
samba3.smb2.timestamps.time_t_1968
samba3.smb2.timestamps.freeze-thaw
samba3.smb2.session.signing-aes-128-cmac
samba3.smb2.session.encryption-aes-128-gcm
samba3.smb2.session.encryption-aes-256-gcm
timeouts for share-cephfs-default-smb2.compound_find and share-cephfs-default-smb2.maxfid

gpfs: (This doesn't have the flapping.gpfs file yet. That rules out the first three failures)
samba3.smb2.create.quota-fake-file
samba3.smb2.session.bind2
samba3.smb2.session.two_logoff
samba3.smb2.timestamps.time_t_15032385535
samba3.smb2.timestamps.time_t_10000000000
samba3.smb2.timestamps.time_t_-1
samba3.smb2.timestamps.time_t_-2
samba3.smb2.timestamps.time_t_1968
samba3.smb2.timestamps.delayed-write-vs-flush
timeouts for smb2.maxfid

@anoopcs9
Copy link
Collaborator

timeouts for share-cephfs-default-smb2.compound_find and share-cephfs-default-smb2.maxfid

timeouts for share-cephfs-default-smb2.compound_find and share-cephfs-default-smb2.maxfid

Interesting to see that smb2.compound_find which is already running successfully timed out when other new tests were added.

@spuiuk
Copy link
Collaborator Author

spuiuk commented Mar 12, 2024

timeouts for share-cephfs-default-smb2.compound_find and share-cephfs-default-smb2.maxfid

timeouts for share-cephfs-default-smb2.compound_find and share-cephfs-default-smb2.maxfid

Interesting to see that smb2.compound_find which is already running successfully timed out when other new tests were added.

This could simply be the fact that I added a 90 second timeout for this set of patches. It may be that the tests take longer than usual for cephfs compared to gpfs and xfs.

@spuiuk
Copy link
Collaborator Author

spuiuk commented Mar 12, 2024

Set of failures for cephfs_ll with the same number of tests.

samba3.smb2.bench.oplock1
samba3.smb2.create.quota-fake-file
samba3.smb2.durable-open-disconnect.open-oplock-disconnect
samba3.smb2.durable-v2-delay.durable_v2_reconnect_delay
samba3.smb2.durable-v2-delay.durable_v2_reconnect_delay_msec
samba3.smb2.durable-v2-open.create-blob
samba3.smb2.durable-v2-open.durable-v2-setinfo
samba3.smb2.durable-v2-open.open-lease
samba3.smb2.durable-v2-open.open-oplock
samba3.smb2.durable-v2-open.persistent-open-lease
samba3.smb2.durable-v2-open.persistent-open-oplock
samba3.smb2.durable-v2-open.reopen1
samba3.smb2.durable-v2-open.reopen1a
samba3.smb2.durable-v2-open.reopen1a-lease
samba3.smb2.durable-v2-open.reopen2
samba3.smb2.durable-v2-open.reopen2b
samba3.smb2.durable-v2-open.reopen2c
samba3.smb2.durable-v2-open.reopen2-lease
samba3.smb2.durable-v2-open.reopen2-lease-v2
samba3.smb2.lock.replay_smb3_specification_durable
samba3.smb2.lock.replay_smb3_specification_multi
samba3.smb2.rw.invalid
samba3.smb2.session.bind1
samba3.smb2.session.bind_invalid_auth
samba3.smb2.session.bind_negative_smb202
samba3.smb2.session.bind_negative_smb210d
samba3.smb2.session.bind_negative_smb210s
samba3.smb2.session.bind_negative_smb2to3d
samba3.smb2.session.bind_negative_smb2to3s
samba3.smb2.session.bind_negative_smb3encGtoCd
samba3.smb2.session.bind_negative_smb3encGtoCs
samba3.smb2.session.bind_negative_smb3signC30toGd
samba3.smb2.session.bind_negative_smb3signC30toGs
samba3.smb2.session.bind_negative_smb3signCtoGd
samba3.smb2.session.bind_negative_smb3signCtoGs
samba3.smb2.session.bind_negative_smb3signCtoHs
samba3.smb2.session.bind_negative_smb3signGtoC30d
samba3.smb2.session.bind_negative_smb3signGtoC30s
samba3.smb2.session.bind_negative_smb3signGtoCd
samba3.smb2.session.bind_negative_smb3signGtoCs
samba3.smb2.session.bind_negative_smb3signGtoH2Xd
samba3.smb2.session.bind_negative_smb3signGtoH2Xs
samba3.smb2.session.bind_negative_smb3signGtoHd
samba3.smb2.session.bind_negative_smb3signGtoHs
samba3.smb2.session.bind_negative_smb3signH2XtoGd
samba3.smb2.session.bind_negative_smb3signH2XtoGs
samba3.smb2.session.bind_negative_smb3signHtoCs
samba3.smb2.session.bind_negative_smb3signHtoGd
samba3.smb2.session.bind_negative_smb3signHtoGs
samba3.smb2.session.bind_negative_smb3sneCtoGd
samba3.smb2.session.bind_negative_smb3sneCtoGs
samba3.smb2.session.bind_negative_smb3sneGtoCd
samba3.smb2.session.bind_negative_smb3sneGtoCs
samba3.smb2.session.bind_negative_smb3sneGtoHd
samba3.smb2.session.bind_negative_smb3sneGtoHs
samba3.smb2.session.bind_negative_smb3sneHtoGd
samba3.smb2.session.bind_negative_smb3sneHtoGs
samba3.smb2.session.bind_negative_smb3to2d
samba3.smb2.session.bind_negative_smb3to2s
samba3.smb2.session.bind_negative_smb3to3d
samba3.smb2.session.bind_negative_smb3to3s
samba3.smb2.session.encryption-aes-128-ccm
samba3.smb2.session.encryption-aes-128-gcm
samba3.smb2.session.encryption-aes-256-ccm
samba3.smb2.session.encryption-aes-256-gcm
samba3.smb2.session.reauth1
samba3.smb2.session.reauth2
samba3.smb2.session.reauth3
samba3.smb2.session.reauth6
samba3.smb2.session.reconnect1
samba3.smb2.session.reconnect2
samba3.smb2.session.signing-aes-128-cmac
samba3.smb2.session.signing-aes-128-gmac
samba3.smb2.session.signing-hmac-sha-256
samba3.smb2.timestamps.freeze-thaw
samba3.smb2.timestamps.time_t_0
samba3.smb2.timestamps.time_t_-1
samba3.smb2.timestamps.time_t_1
samba3.smb2.timestamps.time_t_10000000000
samba3.smb2.timestamps.time_t_15032385535
samba3.smb2.timestamps.time_t_1968
samba3.smb2.timestamps.time_t_-2
samba3.smb2.timestamps.time_t_4294967295

@spuiuk spuiuk mentioned this pull request Mar 13, 2024
Closed
@anoopcs9
Copy link
Collaborator

anoopcs9 commented Apr 4, 2024

@spuiuk Can we have another round of run with just the changes to add extra tests?

@anoopcs9
Copy link
Collaborator

anoopcs9 commented May 15, 2024 •
edited
Loading

/retest centos-ci/cephfs.vfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spuiuk @anoopcs9