Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smbtorture: smb2.bench-oplock no longer exists #69

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Mar 8, 2024

smb2.bench-oplock got renamed to smb2.bench.oplock as a separate test within smb2.bench test suite. Subsequently more tests got added into smb2.bench. Let's remove the old smb2.bench-oplock entry and re-add the test suite after checking feasibility of running the independent tests.

Thanks to @spuiuk for pointing out the following smbtorture notice from our test runs:

_____________ test_smbtorture[share-xfs-default-smb2.bench-oplock] _____________
----------------------------- Captured stdout call -----------------------------
Command: /bin/smbtorture --fullname --option=torture:progress=no --option=torture:sharedelay=100000 --option=torture:writetimeupdatedelay=500000 --format=subunit --target=samba3 --user=test2%x //192.168.123.10/share-xfs-default smb2.bench-oplock|/usr/bin/python3 /root/sit-test-cases/testcases/smbtorture/selftest/filter-subunit --fail-on-empty --prefix=samba3. --expected-failures=/root/sit-test-cases/testcases/smbtorture/selftest/knownfail --expected-failures=/root/sit-test-cases/testcases/smbtorture/selftest/knownfail.d --expected-failures=/root/sit-test-cases/testcases/smbtorture/selftest/expectedfail.d --flapping=/root/sit-test-cases/testcases/smbtorture/selftest/flapping --flapping=/root/sit-test-cases/testcases/smbtorture/selftest/flapping.d --flapping=/root/sit-test-cases/testcases/smbtorture/selftest/flapping.xfs|/usr/bin/python3 /root/sit-test-cases/testcases/smbtorture/selftest/format-subunit


smbtorture 4.21.0pre1-UNKNOWN
Using seed 1709679416
time: 2024-03-05 22:56:56.178866Z
Unknown torture operation 'smb2.bench-oplock'


smbtorture 4.21.0pre1-UNKNOWN
Using seed 1709679416
Unknown torture operation 'smb2.bench-oplock'

ALL OK (0 tests in 0 testsuites)

There might be more detail in ./subunit or ./summary.

smb2.bench-oplock got renamed to smb2.bench.oplock as a separate test
within smb2.bench test suite. Subsequently more tests got added into
smb2.bench. Let's remove the old smb2.bench-oplock entry and re-add
the test suite after checking feasibility of running the independent
tests.

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9 anoopcs9 requested a review from spuiuk March 8, 2024 06:16
Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Looks good.

@anoopcs9 anoopcs9 merged commit b42a387 into samba-in-kubernetes:main Mar 11, 2024
7 of 8 checks passed
@anoopcs9 anoopcs9 deleted the rm-smb2-bench-oplock branch March 11, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants