Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-info.yml: add filesystem variant to the backend #89

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

spuiuk
Copy link
Collaborator

@spuiuk spuiuk commented Jul 8, 2024

This helps us tailor tests for cases where the behaviour changes according to the filesystem variant being used.

In this case, we use it with the smbtorture tests where we select the flapping list for the filesystem-variant and it it doesn't exist, fall back to filesystem file.

@spuiuk
Copy link
Collaborator Author

spuiuk commented Jul 9, 2024

/retest centos-ci/cephfs.vfs

This will allow us to tailor the tests based on the variant of the
filesystem used.

Signed-off-by: Sachin Prabhu <[email protected]>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

The smbtorture results could vary based on the filesystem variant used.
We use the variant passed in the test-info.yml to set the flapping list
used.

Signed-off-by: Sachin Prabhu <[email protected]>
@anoopcs9 anoopcs9 merged commit 5426d82 into samba-in-kubernetes:main Jul 9, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants