Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IHttpLlmFunction.seperated composing bug. #119

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

samchon
Copy link
Owner

@samchon samchon commented Jan 5, 2025

This pull request includes several changes to the codebase to enhance functionality and improve internal handling of schema definitions. The most important changes include version updates, new internal methods, and new test files.

Version Update:

Internal Methods and Schema Handling:

  • src/composers/HttpLlmApplicationComposer.ts: Modified the condition to check if props.model has definitions using the new LlmSchemaComposer.isDefs method.
  • src/composers/LlmSchemaComposer.ts: Added a new internal method isDefs to check if a model has definitions and a corresponding constant IS_DEFS with model-specific implementations. [1] [2]
  • Various files under src/composers/llm/: Added the IS_DEFS constant to multiple schema composer namespaces (ChatGptSchemaComposer, ClaudeSchemaComposer, GeminiSchemaComposer, LlamaSchemaComposer, LlmSchemaV3Composer, LlmSchemaV3_1Composer). [1] [2] [3] [4] [5] [6]

New Test Files:

@samchon samchon added bug Something isn't working enhancement New feature or request labels Jan 5, 2025
@samchon samchon self-assigned this Jan 5, 2025
Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK

@samchon samchon merged commit ba85b68 into master Jan 5, 2025
3 checks passed
@samchon samchon deleted the feat/separate branch January 5, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant