Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #127: ChatGPT and Gemini schema had dropped enum typed description. #128

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

samchon
Copy link
Owner

@samchon samchon commented Jan 23, 2025

This pull request includes several updates and improvements to the @samchon/openapi package, including version updates, bug fixes, and the addition of a new test case.

Version updates:

  • Updated the package version from 2.4.0 to 2.4.1 in package.json.
  • Updated the typia dependency version from 7.3.0 to 7.6.0 in package.json.

Bug fixes:

  • Modified ChatGptSchemaComposer to use attribute.description as a fallback if union[0].description is undefined.
  • Updated OpenApiTypeCheckerBase to spread props.schema instead of props.

New test case:

  • Added a new test case test_issue_127_enum_description to verify the description handling in enum schemas.

@samchon samchon added bug Something isn't working enhancement New feature or request labels Jan 23, 2025
@samchon samchon self-assigned this Jan 23, 2025
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, filesystem, network, shell +59 13.8 MB samchon

View full report↗︎

Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK.

@samchon samchon merged commit fecf39a into master Jan 23, 2025
3 checks passed
@samchon samchon deleted the feat/enum branch January 24, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant