speed up ensuring correct file-permissions are set #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvenRoederer
changed the title
SvenRoederer
force-pushed
the
improve-set-permissions
branch
from
3494f61 to
b5c4eac
Compare
jcormier
requested changes
Feb 27, 2024
jcormier
reviewed
Feb 27, 2024
…peating the commands for every folder
Modifying the permissions only for files that have wrong permissions will speed up container start. A welcome sideeffect is no change of ctime, which helps to prevent not needed external backups.
SvenRoederer
force-pushed
the
improve-set-permissions
branch
from
b5c4eac to
062e3ff
Compare
|
Runtime tested this as backport for my existing v4.1 instance. Difference to master is so small, that there is no other result to be expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During each container start the permissions for all relevant files are changed to have write-permission. For large data folders this will delay startup. Changing the permissions always also updates ctime of the file, which will trigger external backup solutions to include all files, even the content did not change.
This PR will check for incorrect permissions via "find" and only updated these files.