-
Notifications
You must be signed in to change notification settings - Fork 16
fix for large decoded value #3
base: master
Are you sure you want to change the base?
Conversation
e95586e
to
8d2200d
Compare
8d2200d
to
aad1eff
Compare
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 2 -1
Lines 44 42 -2
=====================================
- Hits 44 42 -2 |
Hi! Have you pushed this change to PyPI ? I installed xdelta3 from there and it still produces an error. I checked the installed files and _xdelta3.c contains old version of code, from before the fix. Example strings that reproduce the error:
BTW, in this example, delta is very short despite many 8's inserted. Do you detect repetitions and compress them somehow, in addition to making plain diff comparison? |
This isn't on pypi
This repo is just a wrapper around xdelta, have a look there for details on how the delta encoding works. |
if (result != ENOSPC) { | ||
break; | ||
} | ||
output_alloc = output_alloc * 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add main_free(output_buf);
here to avoid leaking memory.
fix #2