Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ams gbh valkyrie support #899

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Ams gbh valkyrie support #899

wants to merge 23 commits into from

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Jan 25, 2024 •
edited
Loading

Note, this is in direct conflict with the hyrax-4-valkyrie-support branch and its PR. We're trying to avoid a breaking change.

bkiahstroud and others added 23 commits June 27, 2023 11:52
@bkiahstroud
create an object factory that supports Valkyrie
374e126 
All code in this commit has been adapted from Surfliner:
https://github.com/surfliner/surfliner-mirror
@bkiahstroud
temp gem conflict workaround
09de2cc
@ShanaLMoore
⚙️ upgrade dry-monads dependency to ~> 1.5.0
28875a8 
Hyrax 4.0.0 requires a dependency upgrade for
dry-monads. I could not upgrade GBH's bulkrax without
doing this change.

- Issue:
- scientist-softserv/ams#77
- Ref:
- https://github.com/samvera/hyrax/blob/cbe9278b919485f90a37630d3f3157ecef59cd7c/hyrax.gemspec#L48
@ShanaLMoore
🧹 Add extra parameter for fill_in_blank_source_identifiers
df96de6 
gbh got an error that we were passing too many arguments
when setting the source_identifier in the bulkrax config.
ref:
- https://github.com/samvera-labs/bulkrax/wiki/Configuring-Bulkrax#source-identifier
@ShanaLMoore
Revert ":broom: Add extra parameter for fill_in_blank_source_identifi…
bae61a7 
…ers"

This reverts commit df96de6.
@ShanaLMoore
🧹 delegate create_parent_child_relationships from importer to parser
fe51a43
@orangewolf
allow ruby 3 syntax in migrations
3dac0f5
@ShanaLMoore
Merge remote-tracking branch 'origin/i672-valkyrie-support' into hyra…
a9a90ba 
…x-4-valkyrie-support
@ShanaLMoore
🧹 change exists? to exist? to support Ruby 3.2
86adf9a
@ShanaLMoore
🚧 add support for Hyrax 5, valkyrie and ruby 3.2
ba359f6
@kirkkwang
add temp workaround for blank title and creator
e8677bb
@ShanaLMoore
⚙️ Switch find methods with custom queries for Valkyrie
f6fb201
@orangewolf
Merge branch 'main' into hyrax-4-valkyrie-support
1def082
@orangewolf
hyrax 4 permission service does both valk and non-valk
03544c7
@orangewolf
new bagit
2bf6024
@orangewolf
handle validation failure
56101af
@orangewolf
better failure detection for vaklyrie object
759a481
@orangewolf
fix validation message
9724643
@orangewolf
importer failure helpers
ed49dc2
@orangewolf
improve multiple detection in matchers
ba7a071
@orangewolf
fix matcher on missing field
784798d
@orangewolf
rob cant remember that its include?
c2ee9bc
@jeremyf
Merge branch 'main' into ams-gbh-valkyrie-support
ba6933c
@jeremyf jeremyf added the breaking-change for release notes label Jan 25, 2024
@jeremyf jeremyf marked this pull request as draft January 25, 2024 16:53
@ShanaLMoore ShanaLMoore self-requested a review January 25, 2024 16:54
ShanaLMoore
ShanaLMoore requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add specs for valkyrie. Get the specs to pass.

@jeremyf jeremyf mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShanaLMoore ShanaLMoore ShanaLMoore requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
breaking-change for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeremyf @ShanaLMoore @bkiahstroud @orangewolf @kirkkwang