compare entire timestamps of embargo_release_date and current time wh… #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en checking embargoes
jcoyne
previously requested changes
Dec 15, 2016
| embargo_date = Date.parse(self[embargo_key].split(/T/)[0]) | ||
| return embargo_date > Date.parse(Time.now.to_s) | ||
| embargo_date = DateTime.parse(self[embargo_key]) | ||
| return embargo_date > DateTime.parse(Time.now.to_s) |
There was a problem hiding this comment.
Can this be DateTime.current on the right hand side?
There was a problem hiding this comment.
@weiweishi: is that revision OK to you?
jrgriffiniii
dismissed
jcoyne’s stale review
Stale, as this was reviewed more than 7 years ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en checking embargoes
Existing logic checks for date only and it may cause issue with embargo lifting, and giving false status on the embargo release date.