Issue 557 - Assume client is requesting whole file if no range specified #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the clear writeup of the issue and this PR! It looks like the build is broken on an unrelated issue I think I saw on another samvera repo. I can resolve this in a separate PR but it might be a little while. Is getting this fix in urgent for you? |
|
No its not urgent, we have a local override which implements the same fix in the mean time. |
cjcolvar
force-pushed
the
hydra-head-557
branch
from
a89b479
to
6704035
Compare
cjcolvar
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#557
If no range is specified for the Range header, then assume the whole file is being requested by overriding the range value to
"0-". This prevents a error that we get frequently in our logs when clients provide the "Range: bytes=" header on their download requests.@samvera/hydra-head