Add remove services for collections, objects, and related objects. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
elrayle
force-pushed
the
new_service_for_removing
branch
from
742c9de to
ae111d5
Compare
elrayle
force-pushed
the
new_service_for_removing
branch
from
ae111d5 to
7b4486c
Compare
1 similar comment
| @@ -10,8 +10,7 @@ class GetRelatedObjectsFromCollection | |||
|
|
|||
| def self.call( parent_collection ) | |||
| raise ArgumentError, "parent_collection must be a pcdm collection" unless Hydra::PCDM.collection? parent_collection | |||
|
|
|||
| parent_collection.related_objects | |||
| parent_collection.related_objects.to_a | |||
There was a problem hiding this comment.
Do we need to call to_a here? Why? to_a can be less efficient if they only want the first element of the association.
There was a problem hiding this comment.
Two reasons for the related_object.to_a
- related_objects.include? raises an error in some cases (This should be fixed when issue related_objects.delete should return deleted object (not array) or nil samvera-deprecated/activefedora-aggregation#36 is fixed)
- col1.collections and col1.objects in collection_behaviors each returns an Array and is surfaced through services as GetCollectionsFromCollection and GetObjectsFromCollection. For consistency in processing, col1.related_objects surfaced through GetRelatedObjectsFromCollection should return an Array.
NOTE: Same applies for related objects in pcdm objects.
elrayle
force-pushed
the
new_service_for_removing
branch
from
f5e842f to
1c3b809
Compare
New Services: * RemoveCollectionFromCollection * RemoveObjectFromCollection * RemoveRelatedObjectFromCollection * RemoveObjectFromObject * RemoveRelatedObjectFromObject Updated Services: * GetRelatedObjectsFromCollection - return array * GetRelatedObjectsFromObject - return array
elrayle
force-pushed
the
new_service_for_removing
branch
from
1c3b809 to
fd27ef1
Compare
1 similar comment
jcoyne
added a commit
that referenced
this pull request
May 19, 2015
Add remove services for collections, objects, and related objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Services:
Updated Services: