Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update IiifPrint to permission propagation #2201

Merged
merged 1 commit into from
May 1, 2024

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented May 1, 2024

ref:

Issue:

Story

Copies the permissions from the parent work to each of the spawned child works.

Prior to this commit, the child works split off of parent works were assigned permissions according to the parent's current visibility (in the case of a lease or embargo, this means they were assigned the value during lease or embargo).

This would protect the child work during the lease or embargo period but not allow it to be maintained by the expiry jobs, resulting in an incorrect visibility setting at the end of the lease or embargo.

Refs scientist-softserv/iiif_print#347

Expected Behavior Before Changes

Child works were assigned the visibility of the parent. In cases of embargo or lease, this means they were assigned the initial "visibility during..." value.

Expected Behavior After Changes

Child works and child filesets are assigned the same permissions as the parent work.

Screenshots / Video

Child Work

Screenshot 2024-04-30 at 11 13 43 AM

Notes

Testing is blocked by scientist-softserv/iiif_print#343

Due to an unknown source of a change in behavior, filesets in Hyku/hyrax double-combo are still only assigned the initial 'visibility during...' value. This should be addressed in a separate ticket.

@ShanaLMoore ShanaLMoore added the patch-ver for release notes label May 1, 2024
@ShanaLMoore ShanaLMoore marked this pull request as ready for review May 1, 2024 20:10
@ShanaLMoore ShanaLMoore requested a review from laritakr May 1, 2024 20:35
@ShanaLMoore ShanaLMoore merged commit 0a07bf0 into main May 1, 2024
4 of 5 checks passed
@ShanaLMoore ShanaLMoore deleted the i201-propagate-permissions-iiif-print branch May 1, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants