Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i777] - collection metadata clean up #2328

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Sep 18, 2024

  • updates styling to make labels bold in the collection form
  • updates locale helper method to account for collection resources
    • Before, if there wasn't a matching term in the locale it would look like the labels were repeated.

Issue:

BEFORE

image

AFTER

image

- updates styling to make labels bold in the collection form
- updates locale helper method to account for collection resources

Issue:
- scientist-softserv/adventist_knapsack#777
@ShanaLMoore ShanaLMoore added patch-ver for release notes minor-ver for release notes and removed patch-ver for release notes minor-ver for release notes labels Sep 18, 2024
@kirkkwang kirkkwang added patch-ver for release notes and removed patch-ver for release notes labels Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Test Results

    3 files  +  1      3 suites  +1   17m 56s ⏱️ + 4m 36s
2 036 tests +627  1 986 ✅ +616  50 💤 +11  0 ❌ ±0 
2 063 runs  +631  2 011 ✅ +620  52 💤 +11  0 ❌ ±0 

Results for commit 6fda7fd. ± Comparison against base commit dd59dbf.

This pull request removes 41 and adds 668 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e0d185f2-36aa-40c5-adc0-d7e87164ba8f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit d9270343-37e4-4c30-864f-fecda24d6cea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 0f1f948d-f1ab-457e-b9d0-732133615f7e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 3f7beda3-e5e3-494d-a53e-a963dea11f91
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy bcdfe724-f58d-46fb-bc67-a9d5d948f3d4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit abfd08e2-3274-4782-96ff-5deca9f9353a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8880698d-d2c5-4d65-8a99-efb3e6fbd14e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update eff35cd2-e5e1-4784-94ce-533a34e5434e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 59202237-ee45-4057-81c8-d67f48d13a1d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1e79aa4d-59b9-4e37-972a-eb4334b185f5
…
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility create_any when there are collection types that have create access allows create_any
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility create_any when there are no collection types that have create access denies create_any
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Editor role through its User roles allows most abilities but denies ability to destroy and manage discovery
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Editor role through its group memberships allows most abilities but not destroy nor manage_discovery
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Reader role through its User roles allows read abilities but denies others
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Reader role through its group memberships allows read abilities but denies others
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user is a Collection Manager through its User roles allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user is a Collection Manager through its group memberships allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when admin user allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when collection depositor allows deposit related abilities and denies non-deposit related abilities
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore marked this pull request as ready for review September 19, 2024 19:31
@ShanaLMoore ShanaLMoore merged commit 1ebf983 into main Sep 19, 2024
8 checks passed
@ShanaLMoore ShanaLMoore deleted the i777-collection-resource-rework branch September 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants