Add vendor dir to Phan, fix other errors

samwilson · Dec 15, 2024 · b96dee9 · b96dee9
1 parent e98438a
commit b96dee9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.phan/config.php b/.phan/config.php
@@ -3,6 +3,7 @@
 return [
     'directory_list' => [
         'src',
+        'vendor',
     ],
     'exclude_file_regex' => '@^vendor/.*/(tests?|Tests?)/@',
     'exclude_analysis_directory_list' => [

diff --git a/src/PhpFlickr.php b/src/PhpFlickr.php
@@ -26,6 +26,7 @@
 use OAuth\Common\Consumer\Credentials;
 use OAuth\Common\Http\Client\CurlClient;
 use OAuth\Common\Http\Uri\Uri;
+use OAuth\Common\Http\Uri\UriInterface;
 use OAuth\Common\Storage\Memory;
 use OAuth\Common\Storage\TokenStorageInterface;
 use OAuth\OAuth1\Service\Flickr;
@@ -281,8 +282,8 @@ public function getOauthService($callbackUrl = 'oob')
         $factory->registerService('Flickr', PhpFlickrService::class);
         $factory->setHttpClient(new CurlClient());
         $storage = $this->getOauthTokenStorage();
-        /** @var PhpFlickrService $flickrService */
         $this->oauthService = $factory->createService('Flickr', $credentials, $storage);
+        assert( $this->oauthService instanceof PhpFlickrService );
         return $this->oauthService;
     }
 
@@ -295,7 +296,7 @@ public function getOauthService($callbackUrl = 'oob')
      * @param string $perm One of 'read', 'write', or 'delete'.
      * @param string $callbackUrl Defaults to 'oob' ('out-of-band') for when no callback is
      * required, for example for console usage.
-     * @return Uri
+     * @return UriInterface
      */
     public function getAuthUrl($perm = 'read', $callbackUrl = 'oob')
     {