Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterative Quantum Phase Estimation #359

Merged
merged 13 commits into from
Dec 13, 2023

Conversation

JamesB-1qbit
Copy link
Contributor

The iterative Quantum Phase Estimation algorithm using mid-circuit measurements.

Copy link
Collaborator

@ValentinS4t1qbit ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, it looks all minor to me

tangelo/algorithms/projective/iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/tests/test_iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/tests/test_iqpe.py Outdated Show resolved Hide resolved
tangelo/linq/target/target_cirq.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/tests/test_iqpe.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ValentinS4t1qbit ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're close, hopefully this is there last back and forth before merging :)

tangelo/algorithms/projective/iqpe.py Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/tests/test_iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Show resolved Hide resolved
tangelo/algorithms/projective/iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/tests/test_iqpe.py Outdated Show resolved Hide resolved
tangelo/algorithms/projective/tests/test_iqpe.py Outdated Show resolved Hide resolved
tangelo/linq/circuit.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ValentinS4t1qbit ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@ValentinS4t1qbit ValentinS4t1qbit merged commit 8ed6137 into sandbox-quantum:develop Dec 13, 2023
9 checks passed
ValentinS4t1qbit added a commit that referenced this pull request Dec 20, 2023
* Helper class and functions for iFCI fragment import (#351)
* Set the instance in a Qiskit runtime job (#352)
* Added trim_qubits option to Circuit.split() (#353)
* Measurement Controlled operations (CMEASURE) (#334)
* Fix after qiskit update: qiskit_noise_model (#354)
* Bugfix: DMET fragment object initialization from IntegralSolver fixed (#355)
* added explicit mo_coeff for H4_cation (#356)
* VQE get_rdm performance improvements (#357)
* Implementation of Frozen Natural Orbitals (FNO) (#358)
* UHF reference symmetry labels. (#360)
* FNO: NotImplementedError for ROHF (#362)
* Iterative Quantum Phase Estimation (#359)
* README minor changes + feature overview link (#363)
* Add feature list (#364) (#365)

---------

Co-authored-by: Valentin Senicourt <[email protected]>
Co-authored-by: AlexandreF-1qbit <[email protected]>
Co-authored-by: James Brown <[email protected]>
Co-authored-by: James Brown <[email protected]>
Co-authored-by: ValentinS4t1qbit <[email protected]>
ValentinS4t1qbit added a commit that referenced this pull request Dec 20, 2023
* Main to catch up with develop (#344)
* Helper class and functions for iFCI fragment import (#351)
* Set the instance in a Qiskit runtime job (#352)
* Added trim_qubits option to Circuit.split() (#353)
* Measurement Controlled operations (CMEASURE) (#334)
* Fix after qiskit update: qiskit_noise_model (#354)
* Bugfix: DMET fragment object initialization from IntegralSolver fixed (#355)
* added explicit mo_coeff for H4_cation (#356)
* VQE get_rdm performance improvements (#357)
* Implementation of Frozen Natural Orbitals (FNO) (#358)
* UHF reference symmetry labels. (#360)
* FNO: NotImplementedError for ROHF (#362)
* Iterative Quantum Phase Estimation (#359)
* README minor changes + feature overview link (#363)
* Add feature list (#364) (#365)

---------

Co-authored-by: Valentin Senicourt <[email protected]>
Co-authored-by: AlexandreF-1qbit <[email protected]>
Co-authored-by: James Brown <[email protected]>
Co-authored-by: James Brown <[email protected]>
Co-authored-by: ValentinS4t1qbit <[email protected]>
cburdine pushed a commit to cburdine/Tangelo that referenced this pull request May 31, 2024
* Helper class and functions for iFCI fragment import (sandbox-quantum#351)
* Set the instance in a Qiskit runtime job (sandbox-quantum#352)
* Added trim_qubits option to Circuit.split() (sandbox-quantum#353)
* Measurement Controlled operations (CMEASURE) (sandbox-quantum#334)
* Fix after qiskit update: qiskit_noise_model (sandbox-quantum#354)
* Bugfix: DMET fragment object initialization from IntegralSolver fixed (sandbox-quantum#355)
* added explicit mo_coeff for H4_cation (sandbox-quantum#356)
* VQE get_rdm performance improvements (sandbox-quantum#357)
* Implementation of Frozen Natural Orbitals (FNO) (sandbox-quantum#358)
* UHF reference symmetry labels. (sandbox-quantum#360)
* FNO: NotImplementedError for ROHF (sandbox-quantum#362)
* Iterative Quantum Phase Estimation (sandbox-quantum#359)
* README minor changes + feature overview link (sandbox-quantum#363)
* Add feature list (sandbox-quantum#364) (sandbox-quantum#365)

---------

Co-authored-by: Valentin Senicourt <[email protected]>
Co-authored-by: AlexandreF-1qbit <[email protected]>
Co-authored-by: James Brown <[email protected]>
Co-authored-by: James Brown <[email protected]>
Co-authored-by: ValentinS4t1qbit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants